fix(config): handle empty MEMPALACE_HOOKS_AUTO_MINE env var

sha2fiddy · sha2fiddy · commit ec33d187191c · 2026-04-30T09:56:21.000-04:00
diff --git a/mempalace/config.py b/mempalace/config.py
@@ -305,14 +305,18 @@ def hook_auto_mine(self):
 
         Env var ``MEMPALACE_HOOKS_AUTO_MINE`` (or legacy ``MEMPAL_HOOKS_AUTO_MINE``)
         overrides the config file. Accepts ``0``/``false``/``no``/``off`` as
-        falsey; anything else is truthy. Default: ``True`` (preserves existing
+        falsey; anything else (including ``true``/``1``/``yes``/``on``) is
+        truthy. Empty / whitespace-only values are treated as unset and fall
+        back to the config file. Default: ``True`` (preserves existing
         behavior for users who don't opt out).
         """
-        env_val = os.environ.get("MEMPALACE_HOOKS_AUTO_MINE") or os.environ.get(
-            "MEMPAL_HOOKS_AUTO_MINE"
-        )
-        if env_val:
-            return env_val.strip().lower() not in ("0", "false", "no", "off")
+        env_val = os.environ.get("MEMPALACE_HOOKS_AUTO_MINE")
+        if env_val is None:
+            env_val = os.environ.get("MEMPAL_HOOKS_AUTO_MINE")
+        if env_val is not None:
+            stripped = env_val.strip().lower()
+            if stripped:
+                return stripped not in ("0", "false", "no", "off")
         return self._file_config.get("hooks", {}).get("auto_mine", True)
 
     @property
diff --git a/tests/test_config.py b/tests/test_config.py
@@ -176,6 +176,36 @@ def test_hook_auto_mine_legacy_env_prefix():
         del os.environ["MEMPAL_HOOKS_AUTO_MINE"]
 
 
+@pytest.mark.parametrize("empty", ["", "   ", "\t", "\n"])
+def test_hook_auto_mine_empty_env_falls_back_to_config(empty):
+    """Empty / whitespace-only env values must fall back to config, not flip to True."""
+    tmpdir = tempfile.mkdtemp()
+    with open(os.path.join(tmpdir, "config.json"), "w") as f:
+        json.dump({"hooks": {"auto_mine": False}}, f)
+    os.environ["MEMPALACE_HOOKS_AUTO_MINE"] = empty
+    try:
+        cfg = MempalaceConfig(config_dir=tmpdir)
+        assert cfg.hook_auto_mine is False
+    finally:
+        del os.environ["MEMPALACE_HOOKS_AUTO_MINE"]
+
+
+def test_hook_auto_mine_empty_primary_does_not_leak_to_legacy():
+    """An empty primary env var must not silently fall through to the legacy var."""
+    tmpdir = tempfile.mkdtemp()
+    with open(os.path.join(tmpdir, "config.json"), "w") as f:
+        json.dump({"hooks": {"auto_mine": False}}, f)
+    os.environ["MEMPALACE_HOOKS_AUTO_MINE"] = ""
+    os.environ["MEMPAL_HOOKS_AUTO_MINE"] = "true"
+    try:
+        cfg = MempalaceConfig(config_dir=tmpdir)
+        # Primary is set (to ""), so legacy must be ignored; empty -> fall back to config.
+        assert cfg.hook_auto_mine is False
+    finally:
+        del os.environ["MEMPALACE_HOOKS_AUTO_MINE"]
+        del os.environ["MEMPAL_HOOKS_AUTO_MINE"]
+
+
 # --- sanitize_name ---
 
 
