fix(hooks): retarget auto_save toggle at silent-save path after #1021 rebase

sha2fiddy · sha2fiddy · commit eace0ee34495 · 2026-04-22T08:49:03.000-04:00
diff --git a/mempalace/hooks_cli.py b/mempalace/hooks_cli.py
@@ -429,8 +429,6 @@ def _ingest_transcript(transcript_path: str):
     if not path.is_file() or path.stat().st_size < 100:
         return
 
-    from .config import MempalaceConfig
-
     try:
         MempalaceConfig()  # validate config loads
     except Exception:
@@ -497,16 +495,9 @@ def hook_stop(data: dict, harness: str):
         # (v3.3.0+), so if we can't read config, behave as if it's still on.
         silent_guard = True
         try:
-            from .config import MempalaceConfig
-        except ImportError as exc:
-            _log(
-                f"WARNING: could not import MempalaceConfig for stop guard: {exc}; defaulting to silent mode"
-            )
-        else:
-            try:
-                silent_guard = MempalaceConfig().hook_silent_save
-            except AttributeError as exc:
-                _log(f"WARNING: could not read hook_silent_save: {exc}; defaulting to silent mode")
+            silent_guard = MempalaceConfig().hook_silent_save
+        except AttributeError as exc:
+            _log(f"WARNING: could not read hook_silent_save: {exc}; defaulting to silent mode")
         if not silent_guard:
             _output({})
             return
@@ -532,8 +523,6 @@ def hook_stop(data: dict, harness: str):
         _log(f"TRIGGERING SAVE at exchange {exchange_count}")
 
         # Read hook settings from config
-        from .config import MempalaceConfig
-
         try:
             config = MempalaceConfig()
             silent = config.hook_silent_save
diff --git a/tests/test_hooks_cli.py b/tests/test_hooks_cli.py
@@ -707,24 +707,29 @@ def test_stop_hook_disabled_by_config(tmp_path):
 
 
 def test_stop_hook_enabled_by_default(tmp_path):
-    """When config has no hooks section, stop hook blocks normally."""
+    """When auto_save is enabled, stop hook saves silently (systemMessage)."""
     transcript = tmp_path / "t.jsonl"
     _write_transcript(
         transcript,
         [{"message": {"role": "user", "content": f"msg {i}"}} for i in range(SAVE_INTERVAL)],
     )
+    save_result = {"count": 3, "themes": ["auto-save"]}
     with patch("mempalace.hooks_cli.MempalaceConfig") as mock_cfg_cls:
         mock_cfg_cls.return_value.hooks_auto_save = True
-        result = _capture_hook_output(
-            hook_stop,
-            {
-                "session_id": "test",
-                "stop_hook_active": False,
-                "transcript_path": str(transcript),
-            },
-            state_dir=tmp_path,
-        )
-    assert result["decision"] == "block"
+        mock_cfg_cls.return_value.hook_silent_save = True
+        mock_cfg_cls.return_value.hook_desktop_toast = False
+        with patch("mempalace.hooks_cli._save_diary_direct", return_value=save_result):
+            result = _capture_hook_output(
+                hook_stop,
+                {
+                    "session_id": "test",
+                    "stop_hook_active": False,
+                    "transcript_path": str(transcript),
+                },
+                state_dir=tmp_path,
+            )
+    assert "systemMessage" in result
+    assert "3 memories" in result["systemMessage"]
 
 
 def test_precompact_hook_disabled_by_config(tmp_path):
