Skip to content

Conversation

@BentiGorlich
Copy link
Member

  • Put some collections into the new CollectionFactory for easy access to the generator methods
  • Add some more optional @context
  • Add Markdown document for the federation documentation. This is then edited via the new DocumentationGenerateFederationCommand which will be called from the frontend build

@BentiGorlich BentiGorlich self-assigned this Sep 10, 2025
@BentiGorlich BentiGorlich added documentation Improvements or additions to documentation activitypub ActivityPub related issues labels Sep 10, 2025
BentiGorlich added a commit that referenced this pull request Sep 10, 2025
- Put some collections into the new `CollectionFactory` for easy access to the generator methods
- Add some more optional `@context`
- Add Markdown document for the federation documentation. This is then edited via the new `DocumentationGenerateFederationCommand` which will be called from the frontend build
@BentiGorlich BentiGorlich force-pushed the new/federation-documentation branch from 070baae to 5272025 Compare September 10, 2025 20:31

The `@context` property for all Mbin payloads **should** be this:

```json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this will work with our online deployment towards joinmbin.org docs site?

Is this additional command automatically called during the doc building?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ow.. You added this as a separate build step?.. Mhh I see MbinOrg/mbin-docs#12

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish there was a better way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well yes it is not optimal. However it is better than doing it manually in my opinion...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @jwr1 has a better implementation idea? Using more native documentation build framework.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I do not have any ideas for a better way to do this.

It is pretty cool to have this automated though (versus needing to manually update it).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That I fully agree, I'm always pro automation whenever possible!

@BentiGorlich BentiGorlich merged commit 4edd5cf into main Sep 11, 2025
7 checks passed
@BentiGorlich BentiGorlich deleted the new/federation-documentation branch September 11, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

activitypub ActivityPub related issues documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants