Improve marking instances as dead #1707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `DeliverHandler` previously only increased the counter for failed delivers on instance entities already present in the db, it did not create one. This commit changes that, so that this logic can mark instances as dead even if there is not an instance entity for them
BentiGorlich
added
enhancement
melroy89
previously approved these changes
Aug 27, 2025
melroy89
reviewed
Aug 27, 2025
melroy89
approved these changes
Aug 27, 2025
BentiGorlich
deleted the
new/deliver-handler-creating-instance-entities
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DeliverHandlerpreviously only increased the counter for failed delivers on instance entities already present in the db, it did not create one. This commit changes that, so that this logic can mark instances as dead even if there is not an instance entity for them