-
Notifications
You must be signed in to change notification settings - Fork 30
Add instance actor test and remove url field #1698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
After observing a 401 error from mastodon like this:
> {"error":"Verification failed for [email protected] https://gehirneimer.de/i/actor"}
I decided to add a test for the instance actor. I suspect that mastodon actually tried to pull the `url` field of the actor which would result in a 404 causing mastodon to spit out this error. Not 100% sure, but having a pointer to an address we do not serve is pointless, so I removed it
|
I think we can still keep the |
| 'owner' => $actor, | ||
| 'publicKeyPem' => $this->client->getInstancePublicKey(), | ||
| ], | ||
| 'url' => 'https://'.$this->kbinDomain.'/instance-actor', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we maybe just point to /agent? Like: https://kbin.melroy.org/agent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That could be something, yes 🤔
I have no idea whether mastodon expects an activity pub page at this URL though 🤔 Maybe we have to redirect an activity pub request to the correct id 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I just deleted my initial comment. But that was saying something like: I tried to search the documentation about instance actor activitypub protocol body content. But its very hard to find proper documentation about this. Crazy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should for now just leave it out. Maybe we can reach out to the Mastodon devs and ask them how they expect this instance actor to behave...
After observing a 401 error from mastodon like this:
{ "error":"Verification failed for [email protected] https://gehirneimer.de/i/actor" }I decided to add a test for the instance actor. I suspect that mastodon actually tried to pull the
urlfield of the actor which would result in a 404 causing mastodon to spit out this error. Not 100% sure, but having a pointer to an address we do not serve is pointless, so I removed it