Skip to content

Conversation

@BentiGorlich
Copy link
Member

After observing a 401 error from mastodon like this:

{
    "error":"Verification failed for [email protected] https://gehirneimer.de/i/actor"
}

I decided to add a test for the instance actor. I suspect that mastodon actually tried to pull the url field of the actor which would result in a 404 causing mastodon to spit out this error. Not 100% sure, but having a pointer to an address we do not serve is pointless, so I removed it

After observing a 401 error from mastodon like this:
> {"error":"Verification failed for [email protected] https://gehirneimer.de/i/actor"}

I decided to add a test for the instance actor. I suspect that mastodon actually tried to pull the `url` field of the actor which would result in a 404 causing mastodon to spit out this error. Not 100% sure, but having a pointer to an address we do not serve is pointless, so I removed it
@BentiGorlich BentiGorlich self-assigned this Aug 11, 2025
@BentiGorlich BentiGorlich added bug Something isn't working enhancement New feature or request activitypub ActivityPub related issues backend Backend related issues and pull requests labels Aug 11, 2025
@BentiGorlich BentiGorlich requested a review from melroy89 August 12, 2025 19:50
@melroy89
Copy link
Member

I think we can still keep the url. But point to the correct link. I believe we did had some generic Mbin about page (static). This one is perfect: https://kbin.melroy.org/agent

'owner' => $actor,
'publicKeyPem' => $this->client->getInstancePublicKey(),
],
'url' => 'https://'.$this->kbinDomain.'/instance-actor',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That could be something, yes 🤔
I have no idea whether mastodon expects an activity pub page at this URL though 🤔 Maybe we have to redirect an activity pub request to the correct id 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I just deleted my initial comment. But that was saying something like: I tried to search the documentation about instance actor activitypub protocol body content. But its very hard to find proper documentation about this. Crazy.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should for now just leave it out. Maybe we can reach out to the Mastodon devs and ask them how they expect this instance actor to behave...

@BentiGorlich BentiGorlich enabled auto-merge (squash) August 29, 2025 21:32
@BentiGorlich BentiGorlich merged commit f134f88 into main Aug 29, 2025
7 checks passed
@BentiGorlich BentiGorlich deleted the fix/instance-actor-fetch branch August 29, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

activitypub ActivityPub related issues backend Backend related issues and pull requests bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants