Performance Improvements for the new combined front page #1697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BentiGorlich
added
enhancement
BentiGorlich
force-pushed
the
new/combined-front-page-caching
branch
2 times, most recently
from
f31bcb7 to
4bfcc37
Compare
BentiGorlich
force-pushed
the
new/combined-front-page
branch
2 times, most recently
from
efb8031 to
c712fc9
Compare
BentiGorlich
force-pushed
the
new/combined-front-page-caching
branch
from
4bfcc37 to
3cefd8a
Compare
BentiGorlich
force-pushed
the
new/combined-front-page-caching
branch
from
3cefd8a to
76bce66
Compare
BentiGorlich
force-pushed
the
new/combined-front-page
branch
from
c712fc9 to
794797b
Compare
BentiGorlich
force-pushed
the
new/combined-front-page
branch
from
af1ca73 to
1f11333
Compare
BentiGorlich
force-pushed
the
new/combined-front-page-caching
branch
from
76bce66 to
ab65434
Compare
BentiGorlich
force-pushed
the
new/combined-front-page
branch
from
1f11333 to
3da9f39
Compare
BentiGorlich
force-pushed
the
new/combined-front-page-caching
branch
from
ab65434 to
7ee9a1c
Compare
melroy89
previously approved these changes
Sep 21, 2025
BentiGorlich
dismissed
melroy89’s stale review
The base branch was changed.
- add caching to the `ContentRepository` (it still works without the cache being populated) for - user follows - user magazine subscriptions - user domain subscriptions - user blocks - user magazine blocks - user domain blocks - user moderated magazines - add event subscribers to each event changing one of those collections to clear the cache
- add caching to the count query of the `NativeQueryAdapter` (for pagination) - hard set the count to 1000 pages if the result set is expected to be large
BentiGorlich
force-pushed
the
new/combined-front-page-caching
branch
from
7ee9a1c to
6e669d6
Compare
Member
Author
melroy89
reviewed
Sep 23, 2025
|
|
||
| $numResults = null; | ||
| if (!$criteria->magazine && !$criteria->moderated && !$criteria->favourite && Criteria::TIME_ALL === $criteria->time && Criteria::AP_ALL === $criteria->federation && 'all' === $criteria->type) { | ||
| if ('test' !== $this->kernel->getEnvironment() && !$criteria->magazine && !$criteria->moderated && !$criteria->favourite && Criteria::TIME_ALL === $criteria->time && Criteria::AP_ALL === $criteria->federation && 'all' === $criteria->type) { |
Member
There was a problem hiding this comment.
Ideally you don't have test code or switches in production code. So the way to do this is most likely stubbing or mocking the interface.
Member
Author
There was a problem hiding this comment.
Ideally yes, but this is a performance shortcut which is only relevant in production, as it does not report the actual number of results anymore. How would I be making this an interface that shares the same code but not this performance workaround, without duplicating most of the code?
melroy89
approved these changes
Sep 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContentRepository(it still works without the cache being populated) forNativeQueryAdapter(for pagination)I separated it from the other PR (#1696) so it is less convoluted to look at :)