Skip to content

Fix the post comment expanding not working #1613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BentiGorlich merged 1 commit into from
May 26, 2025
Merged

Fix the post comment expanding not working #1613

BentiGorlich merged 1 commit into from
May 26, 2025

Conversation

@BentiGorlich
Copy link
Member

@BentiGorlich BentiGorlich commented May 26, 2025

  • the criteria necessary for sorting the comments was not passed through in all cases, add the missing ones

@BentiGorlich BentiGorlich requested review from jwr1 and melroy89 May 26, 2025 10:24
@BentiGorlich BentiGorlich self-assigned this May 26, 2025
@BentiGorlich BentiGorlich added bug Something isn't working frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end backend Backend related issues and pull requests labels May 26, 2025
@BentiGorlich BentiGorlich mentioned this pull request May 26, 2025
Closed
@BentiGorlich
Fix the post comment expanding not working
73979fc 
- the criteria necessary for sorting the comments was not passed through in all cases, add the missing ones
@BentiGorlich BentiGorlich force-pushed the fix/post-comment-expand branch from 8367c78 to 73979fc Compare May 26, 2025 10:33
melroy89
melroy89 approved these changes May 26, 2025
View reviewed changes
Copy link
Member

@melroy89 melroy89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BentiGorlich BentiGorlich merged commit b92e1db into main May 26, 2025
7 checks passed
@BentiGorlich BentiGorlich deleted the fix/post-comment-expand branch May 26, 2025 11:25
@melroy89
Copy link
Member

melroy89 commented May 26, 2025

So now I'm curious when this https://github.com/MbinOrg/mbin/blob/main/src/Controller/Entry/EntryFrontController.php#L237 XML HttpRequest is requested? Since this particular issue was in the Ajax Controller.

And this XML http request will not need criteria?

@BentiGorlich
Copy link
Member Author

BentiGorlich commented May 27, 2025 •
edited
Loading

This route is only called when infinite scroll is enabled, which I neglected and therefore need to fix everywhere 😅 (different PR) apparently we have no infinite scroll for comments, yet, so this is actually not an issue...
But it was not the issue here. The expand thingy is calling another endpoint.

@BentiGorlich BentiGorlich mentioned this pull request Jun 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@melroy89 melroy89 melroy89 approved these changes

@jwr1 jwr1 Awaiting requested review from jwr1

Assignees

@BentiGorlich BentiGorlich

Labels

backend Backend related issues and pull requests bug Something isn't working frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BentiGorlich @melroy89