Check whether the actor is a User #1573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when creating a post of any kind the actor needs to be a user in the mbin context, so check for that. If the actor is not a user we get a bunch of type errors which severely slow the messengers down
BentiGorlich
added
bug
Member
Author
|
It seems like this does not speed up the processing, but at least the error message is clearer and the messages just get removed from the transport now. I think I just have a ridiculous amount of them in my queue. I just don't know where they are coming from |
Member
Less messengers in transport/queue means less CPU and memory usage of RabbitMQ. Which in general could be beneficial for performance. Especially on very large instances. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this problem with a pleroma post from a group actor. My message rate plummeted:
Which lead to me banning the origin instance. I could not check whether this fix worked, but it should. Either way, since we can get a Magazine from
findActorOrCreateit should be done anyway.