Skip to content

Enable option help + missing text for various options #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
melroy89 merged 5 commits into from
Feb 19, 2025
Merged

Enable option help + missing text for various options #1467

melroy89 merged 5 commits into from
Feb 19, 2025

Conversation

@melroy89
Copy link
Member

@melroy89 melroy89 commented Feb 18, 2025 •
edited
Loading

  • Since commit 0d9711f, the help text seems to be fully disabled (put to hidden) in the option settings sidebar
  • This PR refactor the help section, and show the help text again but as a mouse-over title attribute on the HTML span element.
  • Apply the title improvement to both the enum and switch settings row.
  • Add missing help text for various options, which allows us to better explain the settings towards the user. In more detail and not limited to any length of text.

@melroy89 melroy89 added bug Something isn't working enhancement New feature or request accessibility Accessibility related issues and pull requests labels Feb 18, 2025
@melroy89 melroy89 enabled auto-merge (squash) February 18, 2025 20:04
@melroy89 melroy89 added this to the v1.8.1 milestone Feb 19, 2025
@melroy89 melroy89 merged commit 6bd9b75 into main Feb 19, 2025
7 checks passed
@melroy89 melroy89 deleted the add_title_to_options branch February 19, 2025 12:58
@melroy89 melroy89 added the frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheVillageGuy TheVillageGuy TheVillageGuy approved these changes

@BentiGorlich BentiGorlich Awaiting requested review from BentiGorlich

Assignees

No one assigned

Labels

accessibility Accessibility related issues and pull requests bug Something isn't working enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end

Projects

None yet

Milestone

v1.8.1

Development

Successfully merging this pull request may close these issues.

3 participants

@melroy89 @TheVillageGuy