Render lemmy community links as preview #1454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lemmy community link often looks like: `[[email protected]](https://domain.tld/c/community)` which is just rendered as a link at the moment, render such links as the new inline preview
BentiGorlich
added
enhancement
melroy89
previously approved these changes
Feb 14, 2025
Member
Author
|
I think I want to make one change to this. As learned from previous inline preview changes: the link should only be rendered as inline preview if the linktext is the same as the magazine name |
melroy89
reviewed
Feb 17, 2025
Member
Author
|
Ok so I moved the logic into the parsers now, where I should have put them initially. I also wrote a few tests :) |
Instead of trying to fix the link generated by combination of commonmark and our parsers (the links generated by our parsers are removed because nested links are not allowed), just remove the link syntax surrounding the community- and user-mentions if the handle and domain are contained in the surrounding link.
BentiGorlich
force-pushed
the
new/render-lemmy-community-links
branch
from
251a526 to
31ca955
Compare
melroy89
reviewed
Feb 18, 2025
melroy89
reviewed
Feb 18, 2025
melroy89
reviewed
Feb 18, 2025
melroy89
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lemmy community link often looks like:
[[email protected]](https://domain.tld/c/community)which is just rendered as a link at the moment, render such links as the new inline preview