Fix the NotificationSettingApi
#1450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
BentiGorlich
commented
Feb 12, 2025
BentiGorlich
commented
- fix wrong type errors due to setting it to the sql entity instead of the enum
- add tests for the api controller
- fix wrong type errors due to setting it to the sql entity instead of the enum - add tests for the api controller
BentiGorlich
added
bug
melroy89
approved these changes
Feb 12, 2025
jwr1
approved these changes
Feb 12, 2025
Member
jwr1
left a comment
jwr1
left a comment
There was a problem hiding this comment.
Thank you! I just tried it and it looks like it has fixed the issues I've mentioned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.