Add endpoint to create bookmark list #1410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
BentiGorlich
commented
Jan 31, 2025
BentiGorlich
commented
- add an endpoint to create a bookmark list
- change the http method to set a list as default to PUT
- add an endpoint to create a bookmark list - change the http method to set a list as default to PUT
BentiGorlich
added
enhancement
jwr1
requested changes
Jan 31, 2025
Member
jwr1
left a comment
jwr1
left a comment
There was a problem hiding this comment.
Sorry to add more work, but could the bookmark-list create route be POST and the edit route be PUT.
And I don't know if you'd want to go ahead and change the four bookmark adding/removing routes to PUT in this PR also.
Member
Author
|
Sure no problem, I'll change that |
I let the routes go round go round like a routing pro round round right round
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.