Truncate body content in the production log #1377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BentiGorlich
requested changes
Jan 20, 2025
BentiGorlich
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stops dumping the whole HTML page into the production log.
It now should now truncate the content (similar to what we do at other places) and also give a better warning message as well, since the message was not empty but invalid JSON.
I also do not
json_encodethis body. As you can see above, this doesn't seems to work out very well. Should we encode this? I think we shouldn't.Before:
{"message":"[ActivityHandler::doWork] Activity message from was empty: \"<!DOCTYPE html>\\n<html lang=\\\"en\\\" dir=\\\"ltr\\\" data-critters-container>\\n <head>\\n <meta charset=\\\"UTF-8\\\">\\n <meta name=\\\"viewport\\\" content=\\\"width=device-width, initial-scale=1\\\">\\n\\n <meta name=\\\"theme-color\\\" content=\\\"#fff\\\">\\n <meta property=\\\"og:platform\\\" content=\\\"PeerTube\\\">\\n <!-- Web Manifest file -->\\n <link rel=\\\"manifest\\\" href=\\\"\\/manifest.webmanifest?4c8fd744881396dcfe1523d39ab99685121e6e1a\\\">\\n\\n <link rel=\\\"icon\\\" type=\\\"image\\/png\\\" href=\\\"\\/client\\/assets\\/images\\/favicon.png?2ad41d22c0e341b2d933fd24387cede77d2e2c55\\\">\\n <link rel=\\\"apple-touch-icon\\\" href=\\\"\\/client\\/assets\\/images\\/icons\\/icon-144x144.png\\\" sizes=\\\"144x144\\\">\\n <link rel=\\\"apple-touch-icon\\\" href=\\\"\\/client\\/assets\\/images\\/icons\\/icon-192x192.png\\\" sizes=\\\"192x192\\\">\\n\\n <!-- logo background-image -->\\n <style type=\\\"text\\/css\\\">\\n .icon-logo {\\n background-image: url(\\/client\\/assets\\/images\\/logo.svg?b08484358edad4fa10af4098f76e1c1a96b7ae09);\\n }\\n <\\/style>\\n\\n <!-- base url -->\\n <base href=\\\"\\/client\\/en-US\\/\\\">\\n\\n <!-- \\/!\\\\ The following comment is used by the server to prerender some tags \\/!\\\\ -->\\n\\n <title>peertube - BrooksTube<\ ................................. ................................. \n }\\n\\n if (\\/MSIE|Trident\\/.test(window.navigator.userAgent) ) {\\n displayIncompatibleBrowser()\\n }\\n <\\/script>\\n\\n <my-app>\\n <\\/my-app>\\n\\n <script src=\\\"runtime.edd0f45dd39b5dad.js\\\" type=\\\"module\\\"><\\/script><script src=\\\"polyfills.3093862582b2ff13.js\\\" type=\\\"module\\\"><\\/script><script src=\\\"main.a19e9b79562e194c.js\\\" type=\\\"module\\\"><\\/script><\\/body>\\n<\\/html>\\n\" }, "level":300,"level_name":"WARNING","channel":"app","datetime":"2025-01-18T02:44:56.294739+01:00","extra":{}}