Add twig component rendering to our markdown rendering #1366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BentiGorlich
added
enhancement
BentiGorlich
force-pushed
the
new/use-twig-rendering-for-markdown
branch
from
6245e78 to
a6eddaf
Compare
- new components for rendering inline entries and posts - use components for inline users and magazines - add new appearance setting for displaying the domains of users and magazines - add tags to clear the cache when a URL is used within markdown, but not yet known to the server
BentiGorlich
force-pushed
the
new/use-twig-rendering-for-markdown
branch
from
a6eddaf to
d3410b2
Compare
melroy89
reviewed
Jan 25, 2025
melroy89
reviewed
Jan 25, 2025
melroy89
reviewed
Jan 25, 2025
melroy89
reviewed
Jan 25, 2025
melroy89
reviewed
Jan 25, 2025
- Rename kbin->mbin in const - Rename `kbinUsernam` to `username` in logging - remove newline in appearance options
melroy89
previously approved these changes
Jan 27, 2025
- check the theme settings for showing the user and magazine domain name in all the places I could find
- when a URL is searched for catch and log exceptions - when parsing the local URL in the `ApActivityRepository` check if there is a path before assuming
- this is mostly useful for image only posts, but also a good info for posts in general
melroy89
previously approved these changes
Jan 29, 2025
Member
Author
|
Even when merging with githubs tool it dismisses your review @melroy89 :/ |
Member
Yeah that is very weird. This should be maybe reported to GitHub. |
melroy89
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.