✨ Support custom badge colors and badges in dialog preferences#140
✨ Support custom badge colors and badges in dialog preferences#140Maxr1998 merged 24 commits intoMaxr1998:masterfrom
Conversation
|
Accidentally added option to change badge color as well, you can drop the last commit if you don't want to include that |
Maxr1998
left a comment
Maxr1998
left a comment
There was a problem hiding this comment.
If it's ok for you, I would do some formatting tweaks myself after you fixed my one comment here, that's easier than having to write a lot of suggestions in this review.
library/src/main/java/de/Maxr1998/modernpreferences/helpers/Badge.kt
Outdated
Show resolved
Hide resolved
Sure sounds good |
|
Btw, you might need to rebase your PR onto the latest master to pass the updated check workflows. |
rosenpin
force-pushed
the
feature/badge-in-dialog
branch
from
33cc022 to
2574e3d
Compare
Thanks, done |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
library/src/main/java/de/Maxr1998/modernpreferences/preferences/choice/SelectionAdapter.kt
Fixed
Show fixed
Hide fixed
|
Added deprecation warning and also updated usage in example app that I realized I forgot to change till now |
|
🙃 |
The replacement doesn't really work for properties, and thus is not very useful. Instead, users should read the documentation and update their code manually.
Maxr1998
left a comment
Maxr1998
left a comment
There was a problem hiding this comment.
Sorry for taking so long, my short-term memory has been bad lately, so I simply forgot to finish the review. I ended up doing more changes to the PR than planned, not just formatting, but also some other small tweaks. I hope you don't mind the commit spam (I'll squash it anyways), I mostly wanted to document all my changes for you to see.
|
I think we might need another rebase to drop the already applied commits 😬 If that's ok for you, I'll do that, and then merge. |
|
Thanks man you're great! It's looking much better now, sorry for not making it easier for you |
Maxr1998
force-pushed
the
feature/badge-in-dialog
branch
from
e0965ea to
3fadab0
Compare
Maxr1998
changed the title
2 participants
TODO: