#119 Fix SVG export#135
Merged
MaxMelcher merged 1 commit intoMaxMelcher:mainfrom Feb 26, 2023
matteotrapani:main
Merged
Conversation
Added specific handling of SVG extension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added specific handling of SVG extension to fix issue #119
I could have added a strategy or something to avoid hard-coded strings, but I've seen that there is not a huge usage of these patterns in the code so I didn't want to make a huge PR.
If you have any suggestion please feel free to make them
Furthermore I noticed that on my local PC there is some issues with the tests because only the ones I created were working properly. I fear that it is something related to encoding or culture. Let me know if I can fix it somehow.
Thanks