Use local temp folder to download chromium headless#124
Merged
MaxMelcher merged 1 commit intoMaxMelcher:mainfrom Oct 10, 2022
Merged
Use local temp folder to download chromium headless#124MaxMelcher merged 1 commit intoMaxMelcher:mainfrom
MaxMelcher merged 1 commit intoMaxMelcher:mainfrom
Conversation
Owner
|
Thanks @Zhaph! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current behaviour of the
BrowserFetcherclass tends to leave instances of the headless chromium browser in a.localchromiumfolder relative to the directory the application is called from.This PR updates the
BrowserFetcherto take aBrowserFetcherOptionsthat specifies a directory in the user's local temp folder.I've also updated the Help text on the
chromePathoption to remove the statement about only used if the Mermaid switch is enabled as this is not true.Fixes #121