Big refactoring and two new options.#105
Merged
MaxMelcher merged 16 commits intoMaxMelcher:mainfrom May 2, 2022
Merged
Conversation
.order defines order not processing of a page
Each class in its own file, Logger as interface
Also cleaned up using
adjusted tests accordingly
and a few more messages
avoid rebuilding FileInfos again and again
Solves the 100MB limit of SetContentAsync API Added --chrome-timeout option to control timeouts
Contributor
Author
|
The latest commits added to the PR bring in:
|
Owner
|
wow - what big one... thanks a lot @giuliov |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't be scared by the size of the PR: I did quite a lot of refactoring/reorganizing. I am sorry not being able to submit a smaller PR but I need to break down the
WikiPDFExporterinto manageable and unit-testable chunks.It adds two new options:
--include-unlisted-pagesuse a different algorithm to find markdown pages; it should better match current Wiki behaviour.--exclude-pathsaccepts a list of regular expressions and skip matching pages.For both options, you'll find unit and integration tests. Part of the refactoring was to organize the test files, so it should be easier to add more integration tests.
I have a few more ideas like optimizing memory allocations for big Wikis, but it will be a different PR.
Hope you'll like my changes and approve them.