arm64: cpu_ops: fix a leaked reference by adding missing of_node_put

taskset · wildea01 · commit 92606ec9285f · 2019-04-03T13:50:35.000+01:00
The call to of_get_next_child returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
  ./arch/arm64/kernel/cpu_ops.c:102:1-7: ERROR: missing of_node_put;
  acquired a node pointer with refcount incremented on line 69, but
  without a corresponding object release within this function.

Signed-off-by: Wen Yang &lt;wen.yang99@zte.com.cn&gt;
Reviewed-by: Florian Fainelli &lt;f.fainelli@gmail.com&gt;
Cc: Catalin Marinas &lt;catalin.marinas@arm.com&gt;
Cc: Will Deacon &lt;will.deacon@arm.com&gt;
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Will Deacon &lt;will.deacon@arm.com&gt;
diff --git a/arch/arm64/kernel/cpu_ops.c b/arch/arm64/kernel/cpu_ops.c
@@ -85,6 +85,7 @@ static const char *__init cpu_read_enable_method(int cpu)
 				pr_err("%pOF: missing enable-method property\n",
 					dn);
 		}
+		of_node_put(dn);
 	} else {
 		enable_method = acpi_get_enable_method(cpu);
 		if (!enable_method) {

Original file line number	Diff line number	Diff line change
`@@ -85,6 +85,7 @@ static const char *__init cpu_read_enable_method(int cpu)`
`85`	`85`	`pr_err("%pOF: missing enable-method property\n",`
`86`	`86`	`dn);`
`87`	`87`	`}`
	`88`	`+ of_node_put(dn);`
`88`	`89`	`} else {`
`89`	`90`	`enable_method = acpi_get_enable_method(cpu);`
`90`	`91`	`if (!enable_method) {`