Skip to content

Commit 1d68f58

Browse files
committed
Test make_time
1 parent b67f270 commit 1d68f58

File tree

3 files changed

+38
-13
lines changed

3 files changed

+38
-13
lines changed

sql/core/src/main/scala/org/apache/spark/sql/execution/HiveResult.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ object HiveResult {
7575
ShortType,
7676
DateType,
7777
TimestampType,
78+
TimeType,
7879
BinaryType)
7980

8081
private lazy val dateFormatter = DateFormatter()

sql/core/src/test/resources/sql-tests/inputs/pgSQL/date.sql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -350,12 +350,12 @@ SELECT DATE_TRUNC('DECADE', TO_DATE('0002-12-31 BC', 'yyyy-MM-dd G')); -- 0011-0
350350
select make_date(2013, 7, 15);
351351
-- [SPARK-28471] Formatting dates with negative years
352352
select make_date(-44, 3, 15);
353-
-- select make_time(8, 20, 0.0);
353+
select make_time(8, 20, 0.0);
354354
-- should fail
355355
select make_date(2013, 2, 30);
356356
select make_date(2013, 13, 1);
357357
select make_date(2013, 11, -1);
358-
-- select make_time(10, 55, 100.1);
359-
-- select make_time(24, 0, 2.1);
358+
select make_time(10, 55, 100.1);
359+
select make_time(24, 0, 2.1);
360360

361361
DROP TABLE DATE_TBL;

sql/core/src/test/resources/sql-tests/results/pgSQL/date.sql.out

Lines changed: 34 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
-- Automatically generated by SQLQueryTestSuite
2-
-- Number of queries: 91
2+
-- Number of queries: 94
33

44

55
-- !query 0
@@ -822,32 +822,56 @@ struct<make_date(-44, 3, 15):date>
822822

823823

824824
-- !query 87
825-
select make_date(2013, 2, 30)
825+
select make_time(8, 20, 0.0)
826826
-- !query 87 schema
827-
struct<make_date(2013, 2, 30):date>
827+
struct<make_time(8, 20, CAST(0.0 AS DECIMAL(8,6))):time>
828828
-- !query 87 output
829-
NULL
829+
08:20
830830

831831

832832
-- !query 88
833-
select make_date(2013, 13, 1)
833+
select make_date(2013, 2, 30)
834834
-- !query 88 schema
835-
struct<make_date(2013, 13, 1):date>
835+
struct<make_date(2013, 2, 30):date>
836836
-- !query 88 output
837837
NULL
838838

839839

840840
-- !query 89
841-
select make_date(2013, 11, -1)
841+
select make_date(2013, 13, 1)
842842
-- !query 89 schema
843-
struct<make_date(2013, 11, -1):date>
843+
struct<make_date(2013, 13, 1):date>
844844
-- !query 89 output
845845
NULL
846846

847847

848848
-- !query 90
849-
DROP TABLE DATE_TBL
849+
select make_date(2013, 11, -1)
850850
-- !query 90 schema
851-
struct<>
851+
struct<make_date(2013, 11, -1):date>
852852
-- !query 90 output
853+
NULL
854+
855+
856+
-- !query 91
857+
select make_time(10, 55, 100.1)
858+
-- !query 91 schema
859+
struct<make_time(10, 55, CAST(100.1 AS DECIMAL(8,6))):time>
860+
-- !query 91 output
861+
NULL
862+
863+
864+
-- !query 92
865+
select make_time(24, 0, 2.1)
866+
-- !query 92 schema
867+
struct<make_time(24, 0, CAST(2.1 AS DECIMAL(8,6))):time>
868+
-- !query 92 output
869+
NULL
870+
871+
872+
-- !query 93
873+
DROP TABLE DATE_TBL
874+
-- !query 93 schema
875+
struct<>
876+
-- !query 93 output
853877

0 commit comments

Comments
 (0)