Skip to content

Commit 7f24a41

Browse files
authored
[flutter/flutter] Migrate multiple_windows example to material_ui (flutter#190313)
Migrates the multiple_windows example to material_ui. Part of flutter#190093. ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent 4119b9f commit 7f24a41

16 files changed

Lines changed: 18 additions & 20 deletions

‎examples/multiple_windows/lib/app/dialog_window_content.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
// ignore_for_file: invalid_use_of_internal_member
66
// ignore_for_file: implementation_imports
77

8-
import 'package:flutter/material.dart';
98
import 'package:flutter/src/widgets/_window.dart';
9+
import 'package:material_ui/material_ui.dart';
1010

1111
import 'models.dart';
1212

‎examples/multiple_windows/lib/app/dialog_window_edit_dialog.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
// ignore_for_file: invalid_use_of_internal_member
66
// ignore_for_file: implementation_imports
77

8-
import 'package:flutter/material.dart';
98
import 'package:flutter/src/widgets/_window.dart';
9+
import 'package:material_ui/material_ui.dart';
1010

1111
void showDialogWindowEditDialog({
1212
required BuildContext context,

‎examples/multiple_windows/lib/app/main_window.dart‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
// ignore_for_file: invalid_use_of_internal_member
66
// ignore_for_file: implementation_imports
77

8-
import 'package:flutter/material.dart';
98
import 'package:flutter/src/widgets/_window.dart';
9+
import 'package:material_ui/material_ui.dart';
1010

1111
import 'dialog_window_content.dart';
1212
import 'dialog_window_edit_dialog.dart';
@@ -105,10 +105,7 @@ class _WindowsTable extends StatelessWidget {
105105

106106
void _showWindowEditDialog(BaseWindowController controller, BuildContext context) {
107107
return switch (controller) {
108-
final WindowController regular => showWindowEditDialog(
109-
context: context,
110-
controller: regular,
111-
),
108+
final WindowController regular => showWindowEditDialog(context: context, controller: regular),
112109
final DialogWindowController dialog => showDialogWindowEditDialog(
113110
context: context,
114111
controller: dialog,

‎examples/multiple_windows/lib/app/popup_button.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
// ignore_for_file: invalid_use_of_internal_member
66
// ignore_for_file: implementation_imports
77

8-
import 'package:flutter/material.dart';
98
import 'package:flutter/src/widgets/_window.dart';
9+
import 'package:material_ui/material_ui.dart';
1010

1111
import 'element_position_tracker.dart';
1212
import 'models.dart';

‎examples/multiple_windows/lib/app/popup_window_content.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
// ignore_for_file: invalid_use_of_internal_member
66
// ignore_for_file: implementation_imports
77

8-
import 'package:flutter/material.dart';
98
import 'package:flutter/src/widgets/_window.dart';
9+
import 'package:material_ui/material_ui.dart';
1010

1111
class PopupWindowContent extends StatefulWidget {
1212
/// Creates a popup window widget.

‎examples/multiple_windows/lib/app/popup_window_edit_dialog.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
// ignore_for_file: invalid_use_of_internal_member
66
// ignore_for_file: implementation_imports
77

8-
import 'package:flutter/material.dart';
98
import 'package:flutter/src/widgets/_window.dart';
109
import 'package:flutter/src/widgets/_window_positioner.dart';
10+
import 'package:material_ui/material_ui.dart';
1111
import 'models.dart';
1212

1313
void showPopupWindowEditDialog({

‎examples/multiple_windows/lib/app/rotated_wire_cube.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
import 'dart:math';
66

7-
import 'package:flutter/material.dart';
7+
import 'package:material_ui/material_ui.dart';
88
import 'package:vector_math/vector_math_64.dart';
99

1010
class RotatedWireCube extends StatefulWidget {

‎examples/multiple_windows/lib/app/tooltip_button.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
// ignore_for_file: invalid_use_of_internal_member
66
// ignore_for_file: implementation_imports
77

8-
import 'package:flutter/material.dart';
98
import 'package:flutter/src/widgets/_window.dart';
9+
import 'package:material_ui/material_ui.dart';
1010

1111
import 'element_position_tracker.dart';
1212
import 'models.dart';

‎examples/multiple_windows/lib/app/tooltip_window_content.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77

88
import 'dart:io' show Platform;
99

10-
import 'package:flutter/material.dart';
1110
import 'package:flutter/src/widgets/_window.dart';
11+
import 'package:material_ui/material_ui.dart';
1212

1313
class TooltipWindowContent extends StatelessWidget {
1414
/// Creates a tooltip window widget.

‎examples/multiple_windows/lib/app/tooltip_window_edit_dialog.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
// ignore_for_file: invalid_use_of_internal_member
66
// ignore_for_file: implementation_imports
77

8-
import 'package:flutter/material.dart';
98
import 'package:flutter/src/widgets/_window.dart';
109
import 'package:flutter/src/widgets/_window_positioner.dart';
10+
import 'package:material_ui/material_ui.dart';
1111
import 'models.dart';
1212

1313
void showTooltipWindowEditDialog({

0 commit comments

Comments
 (0)