add invalid arg tests for new bytecodes#167
add invalid arg tests for new bytecodes#167MatthieuDartiailh merged 2 commits intoMatthieuDartiailh:3.14-supportfrom
Conversation
…INARY_OP, FORMAT_VALUE, SPECIAL_METHOD, COMMON_CONSTANT, LOAD_SMALL_INT
|
Let me know if this is what you had in mind |
tests/test_instr.py
Outdated
| label = Label() | ||
| block = BasicBlock() | ||
|
|
||
| if PY314: |
There was a problem hiding this comment.
Since I define dedicated groups of opcode which are version dependent (such as BITFLAG_OPCODES) I would prefer for the tests to use those to avoid duplicating the version checks. Otherwise LGTM (and sorry for the long silence)
There was a problem hiding this comment.
Sure np I'll make the change
There was a problem hiding this comment.
okay I changed to iteration over the opcode groups (like I saw that you do for BITFLAG_OPCODES. It's not super "elegant" because I don't know if you plan to add more opcode to the respective groups...
makslevental
force-pushed
the
3.14-support
branch
from
966cbb7 to
d690475
Compare
|
BTW shouldn't the tests run on this PR? Or do you have it set to only run on your own PRs? |
|
It runs only for PR targeting main. I will merge as is and try to add the test regarding the disassembly of relying on FORMAT_VALUE and BUILD_INTERPOLATION. |
2 participants
tests for validation of the argument of the following instructions: BINARY_OP, FORMAT_VALUE, SPECIAL_METHOD, COMMON_CONSTANT, LOAD_SMALL_INT