Skip to content

Skip ed2k empty links - #46

Merged
MatteoRagni merged 1 commit into
MatteoRagni:masterfrom
RealGreenDragon:fix-add-ed2k-links
Jan 14, 2026
Merged

Skip ed2k empty links#46
MatteoRagni merged 1 commit into
MatteoRagni:masterfrom
RealGreenDragon:fix-add-ed2k-links

Conversation

@RealGreenDragon

Copy link
Copy Markdown
Contributor

Fixed little bug on "ed2k:// - Insert link" forms (in all pages).

Currently if any link is added seems amuleweb adds another empty link before the correct link:

!2025-12-30 18:08:00: ExternalConn: adding link 'ed2k://'.
!2025-12-30 18:08:00: Invalid eD2k link! ERROR: Not a valid ed2k-URI
!2025-12-30 18:08:00: ExternalConn: adding link 'ed2k://|file|<FILE_DATA>/ '.
!2025-12-30 18:08:00: <SUCCESS_MSG>

The cause is the split before amule_do_ed2k_download_cmd call that generate an empty string.
With this fix empty links are filtered and no more strange errors happens:

!2025-12-30 18:10:00: ExternalConn: adding link 'ed2k://|file|<FILE_DATA>/ '.
!2025-12-30 18:10:00: <SUCCESS_MSG>

In meanwhile I removed some extra spaces present in some php files.

@MatteoRagni
MatteoRagni merged commit 3fef80d into MatteoRagni:master Jan 14, 2026
@RealGreenDragon
RealGreenDragon deleted the fix-add-ed2k-links branch January 18, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants