Skip to content

= Fix broken HTML & CSS - #23

Merged
MatteoRagni merged 1 commit into
MatteoRagni:masterfrom
tetreum:master
Feb 25, 2021
Merged

= Fix broken HTML & CSS#23
MatteoRagni merged 1 commit into
MatteoRagni:masterfrom
tetreum:master

Conversation

@tetreum

@tetreum tetreum commented Feb 23, 2021

Copy link
Copy Markdown
Contributor

Uf.....
The way this template got setup makes it impossible to maintain. I understand that because of aMule's PHP, we can't do things like including/requiring in php to avoid duplicated content but what about styles??
Why weren't they placed on a styles.css rather than duplicating them everywhere?

Anyway, i fixed multiple broken styles and html.
Like:
1

Which now looks:
2

Closes #22 , #21

@MatteoRagni

MatteoRagni commented Feb 25, 2021

Copy link
Copy Markdown
Owner

Because when I made it amule gave 404 on everything that is not in the original server.
But feel free to improve it.

@MatteoRagni
MatteoRagni merged commit e872f67 into MatteoRagni:master Feb 25, 2021
@tetreum

tetreum commented Feb 25, 2021

Copy link
Copy Markdown
Contributor Author

Quite strange.
I didn't have any problem creating and using a styles.css. The real problem was that there were slightly differences between all <style> across the files. So i rolledback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search text in italian

2 participants