feat: introduce AbstractEvent and upgrade to node 20.x#2
Merged
CMCDragonkai merged 1 commit intostagingfrom Aug 30, 2023
Merged
feat: introduce AbstractEvent and upgrade to node 20.x#2CMCDragonkai merged 1 commit intostagingfrom
AbstractEvent and upgrade to node 20.x#2CMCDragonkai merged 1 commit intostagingfrom
Conversation
19 tasks
d3c66ef to
59720ec
Compare
Member
Author
|
It is important to realise that |
59720ec to
322eb3d
Compare
Member
Author
|
Weird, the node 20 upgrade may have introduced the Otherwise tests are done. |
Member
Author
|
So this produces try { new CustomEvent('abc', 'abc') } catch (e) { console.log(e instanceof TypeError); }But it works on NodeJS. I think this is a jest error. |
Member
Author
Member
Author
|
In the mean time we will just check the exception name which should work portably. |
322eb3d to
aed9c72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This introduces the
AbstractEventin a similar vein toAbstractErrorin js-errors. It is supposed to be used as the root event class for all event related operations to help govern push-flows.Because
AbstractEventusesCustomEventthis bumps up our nodejs to 20.x which is the next LTS, and hasCustomEventavailable as a global.Notice updates to:
.eslintrcpkgs.nixshell.nixAny downstream packages using this will need to upgrade correspondingly.
Further instructions on utilisation will be in the
README.md.Issues Fixed
js-events) js-quic#53Tasks
AbstractEventEventAnyAbstractEventusesREADME.mdwith proper utilisationFinal checklist