Fixing intermittent failures due to js-quic stream errors#725
Merged
tegefaulkes merged 3 commits intostagingfrom May 23, 2024
Merged
Fixing intermittent failures due to js-quic stream errors#725tegefaulkes merged 3 commits intostagingfrom
js-quic stream errors#725tegefaulkes merged 3 commits intostagingfrom
Conversation
…nagerSignalFailed` error [ci skip]
… returning the request handler [ci skip]
tegefaulkes
force-pushed
the
feature-network-test-isolation
branch
from
378e96a to
d79de26
Compare
Member
|
What are the implications of doing this: Given that |
Contributor
Author
|
Everything functions the same way, we just remove the chance of that |
Member
|
If it still happens on CI, are you sure the fixes actually fix this? If not, perhaps it's better to leave it as is, and find the actual deterministic root cause. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addressed #722
The main problem was during certain circumstances an error that should've been thrown through a stream was escaping the call stack and crashing the program. This was due to improper usage of throw within the stream handlers. This has been resolved within
js-quic.Note that the branch name doesn't describe the problem scope very well. It was created while I was still exploring what the actual issue was. While mainnet connections in tests could still happen, they shouldn't be causing this issue regardless. No amount of interacting with random network traffic should crash the program.
#461 was removed from this PR, it turns out to not actually be a requirement.
Issues Fixed
mainnetconnections #722Tasks
js-quicand update the dependency version pulling in the fixFinal checklist