Skip to content

Adding periodic rediscovery logic#696

Merged
tegefaulkes merged 4 commits intostagingfrom
feature-rediscovery
Apr 15, 2024
Merged

Adding periodic rediscovery logic#696
tegefaulkes merged 4 commits intostagingfrom
feature-rediscovery

Conversation

@tegefaulkes
Copy link
Contributor

@tegefaulkes tegefaulkes commented Apr 10, 2024

Description

This PR addresses periodic rediscovery logic

Issues Fixed

Tasks

  • 1. When a vertex is process, reschedule it.
  • 2. When a vertex has been processed recently then skip.
  • 3. When a vertex fails we need to reschedule it.
  • 4. Track the number of fails for a job and just give up on it if it exceeds a threshold.

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@tegefaulkes tegefaulkes self-assigned this Apr 10, 2024
- Will rediscover each vertex every hour
- If a vertex hasn't successfully processed within 3 days it is removed from consideration

[ci skip]
@tegefaulkes tegefaulkes force-pushed the feature-rediscovery branch from 39c0752 to 459d9fd Compare April 10, 2024 06:38
@tegefaulkes tegefaulkes requested a review from amydevs April 10, 2024 23:39
@tegefaulkes tegefaulkes marked this pull request as ready for review April 11, 2024 03:40
@linear
Copy link

linear bot commented Apr 12, 2024

@tegefaulkes
Copy link
Contributor Author

The persistent data used by Discovery domain has been moved into the GestaltGraph.

@tegefaulkes tegefaulkes merged commit f568f50 into staging Apr 15, 2024
@CMCDragonkai CMCDragonkai changed the title adding periodic rediscovery logic Adding periodic rediscovery logic Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Background Discovery Mechanisms

2 participants