Decentralizing the validation domain#573
Merged
CMCDragonkai merged 1 commit intostagingfrom Oct 12, 2023
Merged
Conversation
CMCDragonkai
force-pushed
the
feature-decentralize-validation
branch
4 times, most recently
from
4395764 to
46ae3dd
Compare
13 tasks
Member
Author
|
This is weirdly breaking |
CMCDragonkai
force-pushed
the
feature-decentralize-validation
branch
from
46ae3dd to
1b7358e
Compare
Member
Author
|
This is done. The Everything else is moved into specific domains. And of course all the parse Ids is in This will affect downstream PK CLI. So now we have finally removed this big nexus point! Imports should be faster. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR decentralizes the validation domain avoiding a nexus point SPOF. Some changes to import paths will be expected.
Issues Fixed
Tasks
parseXinsidesrc/validation/utils.tsinto their respective domains.domain/utils.tsthey should import thesrc/validation/errors.tsasvalidationErrors, seesrc/claims/utils.tsto see how to do this.src/validation/utils.tsshould now be usingdomainUtils.parseXinstead avoiding a centralised import onvalidationdomain as a "many to many" nexus in our codebase.[ ] 4. We can move the- not going to do this, it's fine the way it issrc/validation/index.tsfunctions intosrc/validation/utils.tsand re-export it unscoped insidesrc/validation, allowing one toimport { validate, validateSync } from '../validation';.Final checklist