-
Notifications
You must be signed in to change notification settings - Fork 5
Closed
Labels
developmentStandard developmentStandard developmentr&d:polykey:core activity 1Secret Vault Sharing and Secret History ManagementSecret Vault Sharing and Secret History Management
Description
Specification
Some parts of the code are still using readable-stream. these need to be replaced with webstreams and the readable-stream dependency removed from the package.json.
These usages can be found at
[nix-shell:~/Projects/Polykey]$ ag "from 'readable"
src/vaults/VaultManager.ts
24:import { PassThrough } from 'readable-stream';
src/git/types.ts
1:import type { PassThrough } from 'readable-stream';
src/git/utils.ts
22:import { PassThrough } from 'readable-stream';
Additional context
- Streams are old and legacy and should be refactored to v16 LTS js-encryptedfs#75 - Git related streams may have some relationship with EFS readable stream changes, can also fix that up too (however EFS will cannot use web streams, since it has to simulate node FS streams)
Tasks
[ ] 1. Replace any- replacing with async generatorreadable-streamusage withstream/web.- 2. Remove
readable-streamas a dependency from thepackage.json.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
developmentStandard developmentStandard developmentr&d:polykey:core activity 1Secret Vault Sharing and Secret History ManagementSecret Vault Sharing and Secret History Management