Modernize Python metadata (pyproject.toml)#1013
Modernize Python metadata (pyproject.toml)#1013mkoeppe wants to merge 4 commits intoMathics3:masterfrom
Conversation
|
@mkoeppe I have noticed that since switching over to toml projects the pre-commit hooks are broken due to some weird interaction between poetry when installing isort. To see this run I think something needs to be added to the toml file with regards to isort or poetry configuration. Have you been able to get pre-commit hooks working? If so what versions of Python, isort, and poetry are you using? |
|
I'll check |
|
I also get with upstream master @ 8436347: |
|
Sorry for the noise; this went away as I switched to a non-ancient python. |
|
I've installed the pre-commit now, and it works without problems |
28f465d to
020e769
Compare
|
I think this may have been auto-closed by mistake |
|
@mkoeppe if I did this, I am sorry. |
|
No worries! It happened automatically when Mathics3/mathics-scanner#61 was merged because GitHub parsed my comment in Mathics3/mathics-scanner#61 (comment) as a closing reference. |
In some versions, black seems to want optional "," at the end of the last parameter. In support of getting #1013 to build cleanly
Local fork of #1013 - Adds redoes packaging in the form that 3.12 is going to need since setuptools is deprecated. In the process, something happened with the way that Cython gets run and we were then getting lots of Cython type annotation mismatch failures. So these have been corrected. We could split this into just the Cython corrections and then apply the packaging toml changes in #1013. Your thoughts? @mmatera and @mkoeppe --------- Co-authored-by: Matthias Koeppe <[email protected]>
|
Changes have been included into #1014 |
No description provided.