Repository navigation
sql: regenerate the system parameter catalog for enable_drop_in_use_index - #40323
Merged
Merged
Conversation
…ndex The flag landed in #39098 and the generated catalog in #40217. Neither build saw the other, so main's checked-in catalog lacks the entry and check-no-diff.sh fails on every branch built against it. Co-Authored-By: Claude Fable 5.1 <[email protected]>
mgree
marked this pull request as ready for review
October 28, 2026 21:36
def-
approved these changes
Oct 28, 2026
antiguru
approved these changes
Oct 28, 2026
mgree
enabled auto-merge (squash)
October 28, 2026 21:38
Contributor
Author
|
Ooh, the rare double approval. Thanks, guys! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
mainfailscheck-no-diff.shonsrc/sql/system-parameters.json. #39098 added theenable_drop_in_use_indexflag and #40217 added the generated catalog. Each merged against amainthat did not contain the other, so neither build caught the missing entry.Description
Output of
bin/gen-system-parameter-catalogon currentmain. No code changes.Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.🤖 Generated with Claude Code