Skip to content

ci: ignore the expected marker halt in the 0dt restarted-in-place test - #40221

Merged
ggevay merged 1 commit into
MaterializeInc:mainfrom
ggevay:gabor/ci-ignore-restarted-in-place-halt
Oct 27, 2026
Merged

ggevay merged 1 commit into
MaterializeInc:mainfrom
ggevay:gabor/ci-ignore-restarted-in-place-halt

Conversation

@ggevay

@ggevay ggevay commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

The test/0dt workflow restarted-in-place-after-promotion (#40065) expects its mz_restarted_in_place service to halt with restarted in place, but deployment generation 1 has been promoted. ci-annotate-errors reports every unknown halting process: line, so Zero downtime 2 failed in Nightly 18592 although the workflow passed.

This ignores that message for the 0dt-mz_restarted_in_place-1 service only, so the same halt elsewhere is still reported.

🤖 Generated with Claude Code

@ggevay
ggevay requested a review from a team as a code owner October 27, 2026 09:38
test/0dt's restarted-in-place-after-promotion workflow starts a second
process of the promoted generation with MZ_RESTARTED_IN_PLACE=true and
expects it to halt with "restarted in place, but deployment generation N
has been promoted". ci-annotate-errors reported that halt as an unknown
error, failing Zero downtime although the workflow passed. Ignore it for
that service only, so the same halt elsewhere is still reported.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@ggevay
ggevay force-pushed the gabor/ci-ignore-restarted-in-place-halt branch from d70bb99 to 118d3d0 Compare October 27, 2026 09:46
@ggevay
ggevay requested a review from bosconi October 27, 2026 09:47

@antiguru antiguru left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ggevay
ggevay merged commit 0b9bbe1 into MaterializeInc:main Oct 27, 2026
86 checks passed
@ggevay ggevay added the T-testing Theme: tests or test infrastructure label Oct 27, 2026
@ggevay
ggevay deleted the gabor/ci-ignore-restarted-in-place-halt branch October 27, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-testing Theme: tests or test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants