Repository navigation
SS-528 Fix Iceberg Catalog ALTER CONNECTION panic - #40069
Merged
Merged
Conversation
peterdukelarsen
requested changes
Oct 21, 2026
peterdukelarsen
left a comment
peterdukelarsen
left a comment
Contributor
There was a problem hiding this comment.
Please double check whether this risks logging anything we shouldn't
peterdukelarsen
approved these changes
Oct 22, 2026
peterdukelarsen
added a commit
that referenced
this pull request
Oct 22, 2026
…40101) `StringOrSecret` holds OAuth credentials and AWS session tokens as inline strings whenever the user did not wrap them in a `SECRET`. Its derived `Debug` printed them verbatim, and connection structs are dumped with `{:#?}` on every `ALTER CONNECTION` compatibility failure and on every `RunSink` the cluster reconciles. This moves the redaction into `StringOrSecret`'s own `Debug`, so an inline value prints as `String(<redacted>)` at every dump site, present and future. Secret references still print as `Secret(id)`. The per-field `redacted()` view and the hand-written `Debug` impls on `IcebergCatalogAuth` and `AwsCredentials` from #40069 are removed, since the type now covers them. Usernames, access key IDs and TLS certificates share this type and are redacted too. The `at {field}` compatibility logs still name which field differed. Adds a unit test that checks both `{:?}` and `{:#?}` output. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5.1 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes SS-528 by properly implementing
alter_compatiblefor various Iceberg Catalog and Iceberg Catalog Connection types, which prevent theALTER CONNECTIONstatement from panicking when run on any of these types, or on parent S3 or GCP connections used for s3tables or biglake catalogs.Added a testdrive to confirm the fix.
Also 2 driveby changes, one renaming some variables in
alter_export_connectionsto better match reality, and adding some additional connection cases to the alter_compatible match statement.