Repository navigation
compute: share MV sink batches below 1 MiB by default - #40051
Merged
antiguru merged 1 commit intoOct 23, 2026
Merged
Conversation
Set the compiled-in default of `compute_mv_sink_shared_batch_max_bytes` to 1 MiB, the value CI already runs with and the value production serves through LaunchDarkly. Deployments without LaunchDarkly now coalesce small per-worker MV sink writes into one batch per process, too. Co-Authored-By: Claude Opus 5.5 <[email protected]>
mtabebe
approved these changes
Oct 21, 2026
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets the compiled-in default of
compute_mv_sink_shared_batch_max_bytesto 1 MiB, so MV sinks coalesce small per-worker writes into one batch per process (#37591) without a LaunchDarkly override. CI already runs with 1 MiB, and staging and internal production environments serve it today. Staging A/B results are on CPU-30.Merge after the production LaunchDarkly default moves to 1 MiB. Until then
test/launchdarkly-flag-consistencyreports the compiled default as diverging from production.Part of CPU-30.
🤖 Generated with Claude Code