Repository navigation
Conversation
Alphadelta14
approved these changes
Oct 7, 2026
`enable_metric_sink` has defaulted off since the feature landed, but enabled in CI. Now, default `enable_metric_sink` to true. Every replica of every cluster now renders the `CURATED` definitions, `mz_metric_arrangement_sizes` and `mz_metric_dataflow_errors`, each a dataflow with its own arrangements on that cluster's compute. `CREATE`/`DROP METRIC SINK` and `SHOW METRIC SINKS` become available at the same time. Set corresponding flags in LD so we have a kill switch. NOTE: the two switches are not interchangeable. `enable_metric_sink = false` only stops installs on replicas created after the flip. It does not tear down running sinks, and a reconnecting replica re-renders them from the controller's command history, so a replica restart does not clear them either. To stop sinks that are already running, use `disabled_metric_sinks`, which `reconcile_metric_sinks` converges on by tearing them down.
mtabebe
force-pushed
the
michaelabebe/sql-732-enable-the-metric-sink-feature
branch
from
October 7, 2026 20:54
c13a9e1 to
4ec97ef
Compare
mtabebe
marked this pull request as ready for review
October 8, 2026 10:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable_metric_sinkhas defaulted off since the feature landed, but enabled in CI.Now, default
enable_metric_sinkto true. Every replica of every cluster now renders theCURATEDdefinitions,mz_metric_arrangement_sizesandmz_metric_dataflow_errors, each a dataflow with its own arrangements on that cluster's compute.CREATE/DROP METRIC SINKandSHOW METRIC SINKSbecome available at the same time.Set corresponding flags in LD so we have a kill switch.
NOTE: the two switches are not interchangeable.
enable_metric_sink = falseonly stops installs on replicas created after the flip. It does not tear down running sinks, and a reconnecting replica re-renders them from the controller's command history, so a replica restart does not clear them either. To stop sinks that are already running, usedisabled_metric_sinks, whichreconcile_metric_sinksconverges on by tearing them down.