Repository navigation
ci: nightly TLS check against a public CA endpoint - #39432
Draft
jasonhernandez wants to merge 1 commit into
Draft
jasonhernandez wants to merge 1 commit into
jasonhernandez wants to merge 1 commit into
Conversation
This was referenced Sep 30, 2026
jasonhernandez
force-pushed
the
jason/tls-stack-2-rustls-connector
branch
from
October 27, 2026 07:09
0f0a2dc to
95855dc
Compare
jasonhernandez
force-pushed
the
jason/tls-stack-4-nightly-public-ca
branch
from
October 27, 2026 07:09
29f1b0c to
7d02854
Compare
jasonhernandez
added a commit
that referenced
this pull request
Oct 27, 2026
### Motivation First PR in the TLS migration stack replacing #36085: #39428 (this, OpenSSL handshake tests) → #39430 (rustls Postgres connector) → #39431 (channel binding) and #39432 (nightly public-CA check). #39433 (pgwire-common `TlsStream` bridge) is independent, based on main. These tests pin down today's OpenSSL TLS client behavior in `mz-tls-util` ahead of the rustls migration, which will extend each test with a rustls leg. Split out of #36085. ### Description - `verify_full_trusts_default_store`: with `sslmode=verify-full` and no `sslrootcert`, `make_tls` trusts a CA from the default store (`SSL_CERT_FILE`). - `client_certs_accepted`: `make_tls` presents the configured client certificate to a server that requires one. - Harness: a throwaway `TestCa`, a blocking OpenSSL `SslAcceptor` server on a background thread, and connect/assert helpers. - `tempfile` and `tokio` added as dev-dependencies (both existing workspace deps). No production code changes. ### Verification Ran the tests repeatedly under nextest. Confirmed each fails when its property is broken (no `SSL_CERT_FILE`, no client cert). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Jason Hernandez <[email protected]> Co-authored-by: Claude Opus 5.5 <[email protected]>
jasonhernandez
force-pushed
the
jason/tls-stack-2-rustls-connector
branch
from
October 28, 2026 00:32
95855dc to
0017751
Compare
Add `external_public_ca_endpoint`, which completes a verify-full handshake with s3.amazonaws.com through both `make_tls_rustls` and `make_tls`, checking that each validates a publicly issued chain from the system trust store. It needs external network access, so it returns early unless MZ_TLS_UTIL_TEST_EXTERNAL_CAS is set. The vendored openssl's default verify paths point at its build-time OPENSSLDIR, which does not exist at runtime, so the openssl leg points SSL_CERT_FILE at the system bundle found by openssl-probe. The new `cargo-test-tls-external` Nightly step runs it through the cargo-test composition's `--tls-external` flag, which starts no services. Co-Authored-By: Claude Opus 5.5 <[email protected]>
jasonhernandez
force-pushed
the
jason/tls-stack-4-nightly-public-ca
branch
from
October 28, 2026 05:53
7d02854 to
08ca149
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Part 4 of the TLS migration stack replacing #36085. Stack: #39428 → #39430 → #39431 and #39432 (both based on #39430).
The unit tests use private CAs only. Nothing checks that the connectors validate a real, publicly issued chain from the system trust store.
Description
external_public_ca_endpoint. It completes a verify-full handshake withs3.amazonaws.comthrough bothmake_tls_rustlsandmake_tls. It returns early unlessMZ_TLS_UTIL_TEST_EXTERNAL_CASis set, so PR CI skips it./usr/local/ssl, which doesn't exist at runtime. So the OpenSSL leg pointsSSL_CERT_FILEat the system bundle thatopenssl-probefinds. The dev-dependency is already in the workspace.--tls-externalflag to thecargo-testcomposition that starts no services.cargo-test-tls-externalNightly step. It usesci-builder: stablefor the Rust toolchain, the composition's topics and one automatic retry for network flakes.Verification
Ran locally with the env var set, and the test passes. Without
SSL_CERT_FILE, the OpenSSL leg fails as described above. The pipeline topics lint passes.🤖 Generated with Claude Code