Skip to content

tests: Bump various versions & introduce SQL Server version tests - #36683

Merged
def- merged 1 commit into
MaterializeInc:mainfrom
def-:pr-kafka-redpanda-versions
May 29, 2026
Merged

def- merged 1 commit into
MaterializeInc:mainfrom
def-:pr-kafka-redpanda-versions

Conversation

@def-

@def- def- commented May 22, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@def-
def- force-pushed the pr-kafka-redpanda-versions branch from 75271bb to 713951d Compare May 22, 2026 01:49
@def-
def- requested a review from a team as a code owner May 22, 2026 01:49
@def-
def- force-pushed the pr-kafka-redpanda-versions branch 4 times, most recently from 084465a to d1ace54 Compare May 22, 2026 06:39
@def- def- changed the title tests: Bump kafka/redpanda versions tests: Bump various versions May 22, 2026
@def-
def- force-pushed the pr-kafka-redpanda-versions branch from d1ace54 to 9eceafa Compare May 22, 2026 07:27
@def-
def- requested review from a team as code owners May 22, 2026 07:27
@def-
def- marked this pull request as draft May 22, 2026 08:39
@def-
def- force-pushed the pr-kafka-redpanda-versions branch 11 times, most recently from c92723e to 1c50644 Compare May 22, 2026 14:50
@def-
def- force-pushed the pr-kafka-redpanda-versions branch from 1c50644 to 3ed5706 Compare May 23, 2026 01:02
@def-
def- marked this pull request as ready for review May 23, 2026 02:26
@def-
def- requested a review from a team as a code owner May 23, 2026 02:26
@def-
def- requested review from bosconi and doy-materialize May 23, 2026 02:26
@def- def- changed the title tests: Bump various versions tests: Bump various versions & introduce SQL Server version tests May 23, 2026

@bosconi bosconi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@def-
def- merged commit 036d772 into MaterializeInc:main May 29, 2026
120 checks passed
@def-
def- deleted the pr-kafka-redpanda-versions branch May 29, 2026 12:51
jasonhernandez added a commit that referenced this pull request Jul 7, 2026
The suite was disabled entirely in #36405 after unexplained PEM flakes
(SS-115). While it was dark, the Confluent Platform 7.9.4 -> 8.2.0 bump
(#36683) broke its setup in two ways that nothing caught:

- CP 8.x ships Jetty 12, which moved the JAAS login modules from
  org.eclipse.jetty.jaas.spi to org.eclipse.jetty.security.jaas.spi.
  The schema registry basic-auth realm silently failed to load its
  login module and returned 401 for every request, correct credentials
  included. Point the jaas.config at the new class path.
- CP 8.x brokers negotiate TLS 1.3, where a missing or untrusted
  client certificate fails with different alert text (certificate
  required, alert 116) than TLS 1.2 (bad certificate, alert 42). The
  kafka mssl tests asserted the exact TLS 1.2 wording. Assert only
  that the broker rejected the connection with a TLS alert, since the
  exact text varies with TLS version and OpenSSL build. This is the
  third exact-text loosening in this suite (#30501, #36232).

With both fixes the full suite passes locally against current main
images. The original SS-115 PEM flake did not reproduce in local runs
on either reqwest 0.12 (main) or the 0.13.4 branch.

Co-Authored-By: Claude Fable 5 <[email protected]>
jasonhernandez added a commit that referenced this pull request Jul 7, 2026
… 8.x) (#37470)

## Summary

Re-enables the Kafka auth test suite, disabled since #36405 (SS-115),
and fixes the two breakages that accumulated while it was dark.

## What broke while the suite was disabled

The Confluent Platform 7.9.4 → 8.2.0 bump (#36683) landed three weeks
after the suite was skipped, and broke its setup in two ways nothing
could catch:

1. **Schema registry basic auth returned 401 for everyone.** CP 8.x
ships Jetty 12, which moved the JAAS login modules from
`org.eclipse.jetty.jaas.spi` to `org.eclipse.jetty.security.jaas.spi`.
Our `schema-registry.jaas.config` referenced the old class, so the login
module never loaded and every request, correct credentials included, got
401. Verified directly: `curl -u materialize:sekurity` against the
container → 401 before, 200 after the one-line class-path fix
(wrong/missing creds still 401).
2. **Kafka mssl negative tests asserted TLS 1.2 alert text.** CP 8.x
brokers negotiate TLS 1.3, where a missing/untrusted client certificate
fails with `tlsv13 alert certificate required` (alert 116) instead of
`ssl/tls alert bad certificate` (alert 42). The assertions now check
only that the broker rejected the connection with a TLS alert. The exact
wording is a function of TLS version and OpenSSL build that we do not
control. This is the third exact-text loosening in this suite's history
(#30501, #36232), so the loosening deliberately goes all the way rather
than chasing the new strings.

## On the original SS-115 flake

The `PEM routines:get_name:no start line` flake that got the suite
disabled did not reproduce in local full-suite runs against current main
images (reqwest 0.12) or against the reqwest 0.13.4 branch (#37469).
Timeline evidence from SS-115 itself shows the flake continued after the
reqwest 0.13 revert (#36241), so reqwest was likely misattributed. If it
resurfaces, the `ci-regexp` in SS-115 will link it; the suite being
enabled is what gives us the data to root-cause it.

## Why now

Two in-flight workstreams change exactly the surface this suite covers:
the reqwest 0.13 re-application (#37469) and the rdkafka → AWS-LC switch
(#35941). Landing those with this suite dark is how auth/TLS regressions
reach production unobserved.

## Test plan

- [x] Full suite green locally against main images (all fixes applied)
- [x] Repeated local runs to probe for the SS-115 flake: 8 consecutive
local full-suite passes (5-run loop + 3 individual), plus 2 clean runs
on the reqwest-0.12 main baseline. The PEM flake did not reproduce.
- [ ] Kafka auth 1–3 green in this PR's CI (the un-skip makes them run
here)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Jason Hernandez <[email protected]>
Co-authored-by: Claude Fable 5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants