Repository navigation
crypto: add core crypto infrastructure (mz-ore crypto module) - #35940
Closed
jasonhernandez wants to merge 2 commits into
Closed
jasonhernandez wants to merge 2 commits into
jasonhernandez wants to merge 2 commits into
Conversation
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
jasonhernandez
force-pushed
the
worktree-agent-ab55bf4b
branch
from
April 10, 2026 19:16
56101d3 to
246f9ba
Compare
This was referenced Apr 10, 2026
jasonhernandez
force-pushed
the
worktree-agent-ab55bf4b
branch
from
April 15, 2026 03:28
246f9ba to
07dc000
Compare
Add rustls, aws-lc-rs, hyper-rustls, rcgen, tokio-rustls workspace deps and the mz-ore `crypto` feature with FIPS-aware CryptoProvider helpers. Azure SDK forks patched to support reqwest-rustls-no-provider. Removes the rustls ban from deny.toml. Does NOT bump LaunchDarkly SDK (deferred to end of migration). Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
jasonhernandez
force-pushed
the
worktree-agent-ab55bf4b
branch
from
April 15, 2026 03:31
07dc000 to
fb15fd2
Compare
Removed reference to migration documentation for rustls.
jasonhernandez
marked this pull request as ready for review
April 15, 2026 03:43
This was referenced Apr 15, 2026
antiguru
reviewed
Apr 15, 2026
antiguru
left a comment
antiguru
left a comment
Member
There was a problem hiding this comment.
Seems fine, but I don't have the full context. Left some comments!
Comment on lines
+612
to
+616
| azure_core = { git = "https://github.com/MaterializeInc/azure-sdk-for-rust.git", branch = "mz/enable-reqwest-rustls-no-provider" } | ||
| azure_identity = { git = "https://github.com/MaterializeInc/azure-sdk-for-rust.git", branch = "mz/enable-reqwest-rustls-no-provider" } | ||
| azure_storage = { git = "https://github.com/MaterializeInc/azure-sdk-for-rust.git", branch = "mz/enable-reqwest-rustls-no-provider" } | ||
| azure_storage_blobs = { git = "https://github.com/MaterializeInc/azure-sdk-for-rust.git", branch = "mz/enable-reqwest-rustls-no-provider" } | ||
| azure_svc_blobstorage = { git = "https://github.com/MaterializeInc/azure-sdk-for-rust.git", branch = "mz/enable-reqwest-rustls-no-provider" } |
Member
There was a problem hiding this comment.
Please pin a specific commit. Branches tend to be deleted over time which makes bisecting very hard.
Contributor
Author
|
Azure/azure-sdk-for-rust#4190 opens up a much better approach, so I'm closing this PR and will upgrade to the newer Azure crate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cryptofeature tomz-orewith#[ctor::ctor]auto-install of aws-lc-rs CryptoProviderPart 1 of 7 in the crypto migration from native-tls/OpenSSL to rustls/aws-lc-rs.
Test plan
cargo check --workspacepassescargo check -p mz-ore --features cryptopassescargo deny check licensespassescargo deny check banspasses🤖 Generated with Claude Code