Repository navigation
build(deps): bump kysely from 0.27.4 to 0.28.14 in /console - #35669
Merged
Merged
Conversation
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
def-
approved these changes
Mar 25, 2026
def-
enabled auto-merge (squash)
March 25, 2026 22:32
Bumps [kysely](https://github.com/kysely-org/kysely) from 0.27.4 to 0.28.14. - [Release notes](https://github.com/kysely-org/kysely/releases) - [Commits](kysely-org/kysely@0.27.4...v0.28.14) --- updated-dependencies: - dependency-name: kysely dependency-version: 0.28.14 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
def-
force-pushed
the
dependabot/npm_and_yarn/console/kysely-0.28.14
branch
from
March 26, 2026 08:14
d641c7d to
60a7571
Compare
leedqin
added a commit
that referenced
this pull request
Nov 6, 2026
### Motivation `yarn gen:types` fails with `function "pg_get_serial_sequence" does not exist`. kysely-codegen runs kysely's Postgres introspector for its table query. Since the bump to kysely 0.28 (#35669), that query calls `pg_get_serial_sequence`, which Materialize lacks. kysely 0.29 still does. The query also lists only relkinds `r`, `v` and `p`, so the catalog's builtin materialized views (`m`) never reached the types under kysely-codegen 0.17. #40044's types were generated with both patched by hand in `node_modules`. This also bumps kysely to 0.29 and kysely-codegen to 0.20, superseding #39686. ### Description - `bin/kysely-codegen.ts` runs kysely-codegen programmatically with an introspector that overrides only the table query. kysely-codegen's materialized view query, enum handling and serializer still apply. - The script writes the copyright header to `types/materialize.d.ts`. The codegen output lacks it, and the copyright lint fails without it. - `bin/generate-types` exits on errors, pulls the requested image (a cached `latest` went stale), and stops the container on exit. Before, each run left a container bound to port 6875, and the next run generated types from that old container. - kysely 0.28.17 → 0.29.8 and kysely-codegen 0.17 → 0.20.0: - 0.29 rejects `limit(sql.raw(...))`. `rawLimit` and the lag history limit now call `query.limit(sql.lit(n))`, which still inlines the limit as a literal, as Materialize requires. - `rawLimit` used to append its limit with `modifyEnd`. In 0.29, compiling end modifiers calls `Array.prototype.toSorted`, which Chrome 109 lacks. No console query uses end modifiers now. Neither `rawLimit` caller has an OFFSET or another end modifier, so the compiled SQL is unchanged. - kysely 0.29 is ESM-only and kysely-codegen 0.20 `require`s it, so `yarn gen:types` needs Node 22.12 or later. CI and the Volta pin run Node 26, and #39683 updates `engines.node`. - `types/materialize.d.ts` is regenerated against v26.49.1. kysely-codegen 0.17 and 0.20 produce identical output. - Adds `mz_builtin_columns` and `mz_builtin_index_columns`. - Builtin columns lose their `Generated<>` wrappers, because #40316 changed `pg_attribute.atthasdef` to report no default for them. The console only selects from these relations, where `Generated<T>` and `T` read the same. - Drops the two hand-added `TODO` markers from #39992. The generator now emits `mz_cluster_auto_scaling_strategies` and `mz_cluster_reconfigurations`, and `AUTO_SCALING_MIN_VERSION` still gates them at runtime. The file is now exactly the generator output. Worth checking on the preview, since these run the changed limits: - the Query History list; - a sink's Errors tab; - the freshness lag charts on the environment overview and the cluster pages. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
leedqin
added a commit
that referenced
this pull request
Nov 11, 2026
### Motivation Renovate opens a batch of dependency PRs every week. CI catches most breaks, but last month's Console upgrades hit several it can't see: - renamed config that the new version silently ignores (msw 3's `onUnhandledRequest`); - dev scripts CI never runs (`yarn gen:types` was broken from #35669 until #40550); - APIs and syntax old browsers lack (kysely 0.29's `toSorted`, string-width 8's `v`-flag regexes); - Node floors above `engines.node`; - layout jsdom can't measure (visx 4's `ParentSize`); - version holds a later bump undid (react-virtualized-auto-sizer in #40521). ### Description Adds the `mz-renovate-triage` skill. - `SKILL.md` sorts open Renovate PRs by risk, checks what CI can't, and posts one verdict comment per PR for the approver (Ready to approve, Needs changes, Needs a decision, Waiting on CI, Superseded). It edits that comment in place on later runs and skips PRs whose head hasn't changed. It never approves, merges, closes, labels or pushes. - `lessons.md` records what the Console upgrades of October and November needed, as rules and as a table by package, each with the PR that taught it. - A row in `.agents/skills/README.md`. A scheduled routine runs the skill twice a week. It can also be run by hand, where it shows the comments and asks before posting. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps kysely from 0.27.4 to 0.28.14.
Release notes
Sourced from kysely's releases.
... (truncated)
Commits
91cf3730.28.149e02f3bbump deno kysely dependency.6ef6f63docs: document immediate value behavior in case() then/else (#1753)2fb071bRemove unnecessary ")" in Node SQLite link (#1755)29032eaAdd Node SQLite link to dialects documentation (#1709)054e801test: add sql.lit(string) test case following #1754.e63ceb9fix: string literals are injectable on MySQL when backslash escapes (\\') a...b15c0410.28.136a3c898chore: bump GitHub actions. (#1751)88e6ccachore: bump dependencies. (#1750)Maintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for kysely since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.