Repository navigation
Commit 8be686f
console: Build the freshness table on useUniversalTable
Replaces a hand-rolled table with the shared one: sorting, row clicks and
pagination come with it, and sortRows, SortKey, the sort state and the
header glyphs go. Net 33 lines fewer.
Pagination is the point. "All objects" mounted a row per object, and a
cluster can carry thousands.
The table opens in the order it is given rather than sorting by a named
column. buildFreshnessRows already orders worst first, by whichever
statistic the active predicate judges, so the table follows the
predicate without being told to.
Naming a column instead would pin the order to one statistic. It would
also put the rows with nothing to judge at the top, because a descending
sort reverses the nulls-last comparator.
The empty states move to the page, which drops the emptyMessage prop and
the memo that existed only to keep JSX out of a memoized component.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>1 parent 1cc4651 commit 8be686f
5 files changed
Lines changed: 224 additions & 257 deletions
File tree
- console/src/platform/freshness
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
251 | 251 | | |
252 | 252 | | |
253 | 253 | | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
263 | | - | |
264 | | - | |
265 | | - | |
266 | | - | |
267 | | - | |
268 | | - | |
269 | | - | |
270 | | - | |
271 | | - | |
272 | | - | |
273 | | - | |
274 | | - | |
275 | | - | |
276 | 254 | | |
277 | 255 | | |
278 | 256 | | |
| |||
321 | 299 | | |
322 | 300 | | |
323 | 301 | | |
324 | | - | |
325 | | - | |
326 | | - | |
327 | | - | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
328 | 314 | | |
329 | 315 | | |
330 | 316 | | |
331 | 317 | | |
332 | 318 | | |
333 | 319 | | |
334 | | - | |
335 | | - | |
336 | | - | |
337 | | - | |
338 | | - | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
339 | 331 | | |
340 | 332 | | |
341 | 333 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
68 | | - | |
69 | | - | |
| 67 | + | |
70 | 68 | | |
71 | 69 | | |
72 | 70 | | |
73 | 71 | | |
74 | 72 | | |
75 | 73 | | |
76 | 74 | | |
77 | | - | |
78 | | - | |
79 | | - | |
| 75 | + | |
80 | 76 | | |
81 | 77 | | |
82 | 78 | | |
| |||
88 | 84 | | |
89 | 85 | | |
90 | 86 | | |
91 | | - | |
92 | | - | |
93 | | - | |
| 87 | + | |
94 | 88 | | |
95 | 89 | | |
96 | 90 | | |
97 | 91 | | |
98 | 92 | | |
99 | 93 | | |
100 | 94 | | |
101 | | - | |
102 | | - | |
103 | | - | |
| 95 | + | |
104 | 96 | | |
105 | 97 | | |
106 | 98 | | |
| |||
109 | 101 | | |
110 | 102 | | |
111 | 103 | | |
112 | | - | |
113 | | - | |
114 | | - | |
| 104 | + | |
115 | 105 | | |
116 | 106 | | |
117 | 107 | | |
| |||
124 | 114 | | |
125 | 115 | | |
126 | 116 | | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
| 117 | + | |
132 | 118 | | |
133 | 119 | | |
134 | 120 | | |
135 | 121 | | |
136 | 122 | | |
137 | 123 | | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
144 | 145 | | |
| 146 | + | |
145 | 147 | | |
146 | | - | |
147 | | - | |
148 | | - | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
149 | 152 | | |
150 | 153 | | |
0 commit comments