Conversation
Defaults to the original value of "0, 16" and as such is an opt-in feature.
nicolaihenriksen
changed the title
Keboo
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3747
This PR adds an attached property,
MenuAssist.MenuItemsPresenterMargin, which can be used to control the "margin on theItemsPresenter" of the menu variants. Technically it is applied on aGridone level above, but the effect is the same.This allows consumers to control the margin as they see fit. The AP defaults to
"0, 16"which was the value previously hardcoded in the templates.I have also aligned the "menus" pages of the demo apps, and showcased usage of the new AP in there.