Skip to content

Add support for SQL #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattfarina merged 1 commit into from
Mar 9, 2020
Merged

Add support for SQL #131

mattfarina merged 1 commit into from
Mar 9, 2020

Conversation

@ryancurrah
Copy link
Contributor

@ryancurrah ryancurrah commented Oct 21, 2019 •
edited
Loading

@ryancurrah ryancurrah mentioned this pull request Oct 21, 2019
Closed
@ryancurrah
Copy link
Contributor Author

ryancurrah commented Oct 23, 2019

@mattfarina not sure if you have had a chance to take a peek yet. do you see any issues? i tried copying for the most what was done for json

@ryancurrah
Copy link
Contributor Author

ryancurrah commented Dec 30, 2019

@mattfarina hope all is well. do you think this is a valid enhancement?

@mattfarina mattfarina self-requested a review February 13, 2020 17:51
mattfarina
mattfarina approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@mattfarina mattfarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow response. I looked this over, looked at package sizing to see how much the new dependencies would add, and some other detail.

This looks acceptable.

@mattfarina mattfarina merged commit 0ce76fe into Masterminds:master Mar 9, 2020
@ryancurrah
Copy link
Contributor Author

ryancurrah commented Mar 9, 2020

All good @mattfarina. Thank you!

@mh-cbon mh-cbon mentioned this pull request May 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattfarina mattfarina mattfarina approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ryancurrah @mattfarina