Get rid of ctype #206
Merged
Get rid of ctype #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jun 9, 2021
| { | ||
| $code = ord($input); | ||
|
|
||
| return ($code >= 97 && $code <= 122) || ($code >= 65 && $code <= 90); |
Contributor
There was a problem hiding this comment.
to import readability of the code, you might replace the numbers with \ord('A') and so on. PHP optimizes such calls (qualified calls to ord with a static string as argument) at compile time, so the runtime is the same than putting the number directly. But it makes it easier to understand what the code is about (as it avoids magic numbers)
Member
|
the suggested improvement can be done later, i'm merging this. I want to prepare a new release soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if 1-2% slower it does not depend on system locale as ctype functions. Polyfills are even slower.
Fixes #173