Fix issue due to go/build.ImportDir change response on not found dir - #910
Merged
Conversation
In go 1.9 there was a change to the way ImportDir, or rather Import
with a local "." package, responded when not found. Previously,
the error was an OS not found error that could be detected by
os.IsNotExist. Now the error is a custom go error using the format:
fmt.Errorf("cannot find package %q in:\n\t%s", path, p.Dir)
This change looks for both cases. For Go 1.9 is checks of it doesn't
exist because there are similar errors in go/build.
For more detail on the Go side of this see golang/go#21923
Member
Author
|
@sdboyer you might be interested in this error. Or, maybe you already have this one down. |
Member
|
ah, thanks for the heads-up! we moved away from directly using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In go 1.9 there was a change to the way ImportDir, or rather Import
with a local "." package, responded when not found. Previously,
the error was an OS not found error that could be detected by
os.IsNotExist. Now the error is a custom go error using the format:
This change looks for both cases. For Go 1.9 is checks of it doesn't
exist because there are similar errors in go/build.
For more detail on the Go side of this see golang/go#21923