Log VCS error output as debug messages - #533
Merged
Merged
Conversation
Member
|
Thanks for your contribution. I understand your frustration. Thanks for helping to make it better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables logging of VCS error output when
--debugis enabled.I don't know if this is the ideal design — to be sure, the VCS error isn't ideal, and there's no central error reporting mechanism other than
msg, which is why I extract the error there.If I were to improve this, it'd be to encapsulate "some program failed to run and this is its failure info" as an error interface.
But I was fed up with getting unhelpful error messages ("Unable to get repository") from Glide, and this fixes that.