glide list: support json output format - #365
Merged
Merged
Conversation
Member
|
I like this a lot. |
Member
|
@chancez First, nice work on this. I like seeing this as json and json-pretty. I can use that myself. I do have some feedback for changes (more on that in a moment). If you're not going to have time just let me know and I can make them via an additional commit. |
| jsonPrettyFormat = "json-pretty" | ||
| ) | ||
|
|
||
| func outputList(l action.PackageList, format string) { |
Member
There was a problem hiding this comment.
The glide.go file is already fairly long. Can we move outputList into action/list.go. Maybe instead of action.List returning something it takes in the format switch and handles the display. That's how the other commands work.
mattfarina
added a commit
that referenced
this pull request
Apr 19, 2016
Member
|
@chancez thanks for the contribution. I finished the tweaks off. |
Contributor
Author
|
@mattfarina Yeah, sorry, I was planning on finishing it off, but you were so quick, so I don't mind! Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort of addresses #256. Might be worth having a format which spits out a newline delimited list, without the "INSTALLED/MISSING/GOPATH packages" headers.