Implement IMobileObjectMetastate on ReadOnlyListBase#4766
Merged
Conversation
…ate tests Co-authored-by: rockfordlhotka <[email protected]>
Co-authored-by: rockfordlhotka <[email protected]>
Co-authored-by: rockfordlhotka <[email protected]>
Copilot
AI
changed the title
[WIP] Implement IMobileObjectMetastate in ReadOnlyListBase
Implement IMobileObjectMetastate on ReadOnlyListBase
Nov 15, 2025
JasonBock
approved these changes
Nov 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder: Make sure to review CONTRIBUTING.MD and make sure you've sent in your signed contributor agreement.
Reminder: Add issue number for work item (e.g. #123)
Description
Implements
IMobileObjectMetastateinterface onReadOnlyListBaseto enable metastate serialization of theIsReadOnlyproperty, completing the interface coverage across CSLA's collection types.Changes
ReadOnlyListBase.cs
IMobileObjectMetastateinterface implementation withGetMetastate()/SetMetastate()methods delegating toMobileObjectMetastateHelperMobileObjectMetastateHelper.cs
ConvertJsonElement()to handle JSON deserialization returningJsonElementinstead of primitive types (bool, int, etc.)PopulateSerializationInfo()to convertJsonElementvalues before adding toSerializationInfoReadOnlyListBaseMetastateTests.cs
IsReadOnlyproperty round-tripping through metastate serializationThe JsonElement conversion fix addresses a limitation where
System.Text.Jsondeserializesobject?properties asJsonElementrather than the actual primitive type, causingInvalidCastExceptionduringSerializationInfo.GetValue<T>()calls.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.