#4729 Update to correctly generate codegen nuget packages#4730
Merged
Conversation
Contributor
|
I'll try these changes tomorrow or the day after locally. |
StefanOssendorf
requested changes
Oct 8, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project files for CSLA code generators to properly generate NuGet packages with correct packaging configurations. The changes ensure that the generators can be consumed as development dependencies with proper isolation of their dependencies.
- Added NuGet-specific packaging properties (
IsPackable,DevelopmentDependency,SuppressDependenciesWhenPacking) - Enhanced dependency management for the AutoImplementProperties generator to include required runtime dependencies
- Cleaned up formatting by removing unnecessary blank lines
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Csla.Generator.AutoSerialization.CSharp.csproj | Added NuGet packaging properties and removed extra blank lines |
| Csla.Generator.AutoImplementProperties.CSharp.csproj | Added NuGet packaging properties, enhanced Microsoft.Bcl.HashCode dependency handling, and removed extra blank lines |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.