Remove Backport.System.Threading.Lock dependency#4724
Merged
Conversation
Contributor
|
You could have used it as a source generator and that would have not made any transitive dependencies to the consumers. It is only transitive as it is not being used as a source generator. |
Contributor
Author
|
I tried that but got errors that the type is already present in other assemblies. I think we have InternalsVisibleTo in use which causes that. Instead of investing time to fix that I opted and discussed the removal with Rocky. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
Backport.System.Threading.Lockdependency fromCslato avoid shipping it as a source generator to consumers.Closes #4450