Skip to content

#4684 #4686 updated Refresh and SaveAsync async methods to return a T…#4697

Merged
rockfordlhotka merged 1 commit into
mainfrom
feature/4684-4686-ReturnTasks
Jun 30, 2025
Merged

#4684 #4686 updated Refresh and SaveAsync async methods to return a T…#4697
rockfordlhotka merged 1 commit into
mainfrom
feature/4684-4686-ReturnTasks

Conversation

@Bowman74

@Bowman74 Bowman74 commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

…ask instead of void.

Closes #4684
Closes #4686

@Bowman74

Copy link
Copy Markdown
Contributor Author

Looks like the CI build detected the shared xaml files that changed and kicked of the MAUI build job as a result. Exactly as designed.

@Bowman74 Bowman74 marked this pull request as ready for review June 30, 2025 16:47
@rockfordlhotka

Copy link
Copy Markdown
Member

@Bowman74 you need to put the issue numbers directly in the PR issue text, not in the title, otherwise they don't link together.

@rockfordlhotka rockfordlhotka merged commit 4b2c7e7 into main Jun 30, 2025
2 checks passed
@rockfordlhotka rockfordlhotka deleted the feature/4684-4686-ReturnTasks branch June 30, 2025 19:02
@Bowman74

Copy link
Copy Markdown
Contributor Author

@Bowman74 you need to put the issue numbers directly in the PR issue text, not in the title, otherwise they don't link together.

Ah wow, that works in ADO. Noted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NRT: Csla.Xaml.Shared.ViewModel{T}.SaveAsync is async void NRT: Csla.Xaml.Shared.CslaDataProvider.Refresh<T> is async void

2 participants